Removing clipping for deleted objects and keeping them deleted #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested first - all good except for the newest commit -- showed Tobias the issue, and he fixed it asap! |
syuil
approved these changes
Jan 5, 2023
tobywisener
commented
Jan 8, 2023
| @@ -282,8 +287,10 @@ void readValues(Buffer buffer) { | |||
| } else if (opcode == 15) { | |||
| objectSizeY = buffer.readUnsignedByte(); | |||
| } else if (opcode == 17) { | |||
| clipType = 0; | |||
There was a problem hiding this comment.
If anyones reading this and copying these changes to their server, do not include these opcode changes - they will cause bugs (I had to revert them)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously door clipping wasnt removed when doors were opened, webs weren't walkable after being slashed, etc etc